fix(universaldb): preserve plain set values#4952
Conversation
PR Review: fix(universaldb): preserve plain set valuesOverview This PR fixes a data-corruption bug in What the bug wasThe deleted
Any arbitrary binary value matching this pattern would be silently corrupted. The comments in both drivers acknowledged this with The fix is correct: a plain Code quality
Issues / suggestionsMinor: test comment should clarify WHY this specific byte pattern matters The test name Minor: test comment capitalisation The inline comment Observation: versionstamped set path is not covered by this diff This PR correctly fixes the plain Test coverageThe new integration test is well-targeted: it stores a value that would have been corrupted by the old heuristic, reads it back, and asserts byte-for-byte equality. It runs as part of SummaryStraightforward and correct bug fix. The two minor comment style issues are the only non-blocking suggestions. No correctness, performance, or security concerns. |
4f8735e to
ee08c9b
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4952All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-43f6721
docker pull rivetdev/engine:full-43f6721Individual packagesnpm install rivetkit@pr-4952
npm install @rivetkit/react@pr-4952
npm install @rivetkit/rivetkit-napi@pr-4952
npm install @rivetkit/workflow-engine@pr-4952 |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: